util.xml: Do not allow doctypes, comments or processing instructions Yes. This is as bad as it sounds. CVE pending. In Prosody itself, this only affects mod_websocket, which uses util.xml to parse the <open/> frame, thus allowing unauthenticated remote DoS using Billion Laughs. However, third-party modules using util.xml may also be affected by this. This commit installs handlers which disallow the use of doctype declarations and processing instructions without any escape hatch. It, by default, also introduces such a handler for comments, however, there is a way to enable comments nontheless. This is because util.xml is used to parse human-facing data, where comments are generally a desirable feature, and also because comments are generally harmless.

     1

#ifndef _POSIX_C_SOURCE

     2

#define _POSIX_C_SOURCE 199309L

     3

#endif

     4

     5

#include <time.h>

     6

#include <lua.h>

     7

     8

lua_Number tv2number(struct timespec *tv) {

     9

	return tv->tv_sec + tv->tv_nsec * 1e-9;

    10

}

    11

    12

int lc_time_realtime(lua_State *L) {

    13

	struct timespec t;

    14

	clock_gettime(CLOCK_REALTIME, &t);

    15

	lua_pushnumber(L, tv2number(&t));

    16

	return 1;

    17

}

    18

    19

int lc_time_monotonic(lua_State *L) {

    20

	struct timespec t;

    21

	clock_gettime(CLOCK_MONOTONIC, &t);

    22

	lua_pushnumber(L, tv2number(&t));

    23

	return 1;

    24

}

    25

    26

int luaopen_util_time(lua_State *L) {

    27

	lua_createtable(L, 0, 2);

    28

	{

    29

		lua_pushcfunction(L, lc_time_realtime);

    30

		lua_setfield(L, -2, "now");

    31

		lua_pushcfunction(L, lc_time_monotonic);

    32

		lua_setfield(L, -2, "monotonic");

    33

	}

    34

	return 1;

    35

}