mod_rest: Catch and log errors in callback promise chain
authorKim Alvefur <zash@zash.se>
Sun, 15 Nov 2020 16:25:49 +0100
changeset 4253 64aa1d9d70ac
parent 4252 f3fbfde9683d
child 4254 8b489203e4d3
mod_rest: Catch and log errors in callback promise chain From the code it looks like it should be possible to reply to an error stanza, but it did not. Turns out I was saved by my local developer mode module which throws errors if an attempt is made to create an errror reply to an error stanza. However nothing collects this error from the promise, so all I got was confusion.
mod_rest/mod_rest.lua
--- a/mod_rest/mod_rest.lua	Sun Nov 15 15:41:52 2020 +0100
+++ b/mod_rest/mod_rest.lua	Sun Nov 15 16:25:49 2020 +0100
@@ -392,6 +392,8 @@
 			function (err)
 				module:log_status("error", "Could not connect to callback URL %q: %s", rest_url, err);
 				origin.send(st.error_reply(stanza, "wait", "recipient-unavailable", err.text));
+			end):catch(function (err)
+				module:log("error", "Error[rest]: %s", err);
 			end);
 
 		return true;