safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:37:37 +0100
changeset 50612 f013e790d8bf
parent 50611 832df74a488f
child 50613 ae2de4cb7869
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/templateutil.py
--- a/mercurial/templateutil.py	Thu Feb 02 17:37:31 2023 +0100
+++ b/mercurial/templateutil.py	Thu Feb 02 17:37:37 2023 +0100
@@ -307,7 +307,7 @@
         return hybriditem(None, key, val, self._makemap)
 
     def filter(self, context, mapping, select):
-        if util.safehasattr(self._values, b'get'):
+        if util.safehasattr(self._values, 'get'):
             values = {
                 k: v
                 for k, v in self._values.items()