run-tests: unnecessary globs also count as warnings
authorSimon Heimberg <simohe@besonet.ch>
Thu, 13 Feb 2014 08:29:44 +0100
changeset 20510 edfbcc3163a8
parent 20509 8ac08939c3fc
child 20511 5840da876235
run-tests: unnecessary globs also count as warnings When a glob is unnecessary, now there's a diff output and 'run-tests.py -i' works for accepting the output. On windows, some tests which have "passed" currently (with some info lines printed) will now be reported as "warned". (I recommend to recognize "warned" by buildbot before applying this patch.)
tests/run-tests.py
--- a/tests/run-tests.py	Thu Feb 13 08:27:53 2014 +0100
+++ b/tests/run-tests.py	Thu Feb 13 08:29:44 2014 +0100
@@ -799,9 +799,8 @@
                     lout = el[:-1] + ' (glob)\n'
                     r = 0 # warn only
                 elif r == '-glob':
-                    log('\ninfo, unnecessary glob in %s (after line %d):'
-                        ' %s (glob)\n' % (test, pos, el[:-1]))
-                    r = True # pass on unnecessary glob
+                    lout = ''.join(el.rsplit(' (glob)', 1))
+                    r = 0 # warn only
                 else:
                     log('\ninfo, unknown linematch result: %r\n' % r)
                     r = False