Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
tests: don't use /dev/urandom for largefiles testing stable
authorMads Kiilerich <mads@kiilerich.com>
Mon, 23 Apr 2012 01:56:48 +0200
branchstable
changeset 16494 e1f0305eabe4
parent 16493 72c6240a4b7d
child 16495 5f9835ed3d6d
tests: don't use /dev/urandom for largefiles testing There is no need to use entropy here just to create some content that only will be used for hashing and ignored. This avoids a problem where dd from /dev/urandom on solaris generates too short output.
contrib/check-code.py file | annotate | diff | comparison | revisions
tests/test-largefiles.t file | annotate | diff | comparison | revisions 
--- a/contrib/check-code.py	Sun Apr 22 21:27:52 2012 -0400
+++ b/contrib/check-code.py	Mon Apr 23 01:56:48 2012 +0200
@@ -74,6 +74,7 @@
     (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
     (r'^alias\b.*=', "don't use alias, use a function"),
     (r'if\s*!', "don't use '!' to negate exit status"),
+    (r'/dev/u?random', "don't use entropy, use /dev/zero"),
   ],
   # warnings
   []
--- a/tests/test-largefiles.t	Sun Apr 22 21:27:52 2012 -0400
+++ b/tests/test-largefiles.t	Mon Apr 23 01:56:48 2012 +0200
@@ -815,7 +815,7 @@
 
 Test --normal flag
 
-  $ dd if=/dev/urandom bs=2k count=11k > new-largefile 2> /dev/null
+  $ dd if=/dev/zero bs=2k count=11k > new-largefile 2> /dev/null
   $ hg add --normal --large new-largefile
   abort: --normal cannot be used with --large
   [255]
@@ -945,7 +945,7 @@
   $ cd alice
   $ hg init pubrepo
   $ cd pubrepo
-  $ dd if=/dev/urandom bs=1k count=11k > a-large-file 2> /dev/null
+  $ dd if=/dev/zero bs=1k count=11k > a-large-file 2> /dev/null
   $ hg add --large a-large-file
   $ hg commit -m "Add a large file"
   Invoking status precommit hook
mercurial