minifileset: note the unsupported file pattern when raising a parse error stable
authorMatt Harbison <matt_harbison@yahoo.com>
Wed, 24 Jan 2018 22:26:28 -0500
branchstable
changeset 35800 d5288b966e2f
parent 35799 b91bca85ba73
child 35801 373fb3f5922c
minifileset: note the unsupported file pattern when raising a parse error This was useful in debugging, because I stupidly quoted it out of habit from the command line. This isn't a great example that clearly shows the problem, but I don't know how to improve it. The problem *is* obvious once a complex statement or a clearly bogus string is used.
mercurial/minifileset.py
tests/test-lfs.t
--- a/mercurial/minifileset.py	Tue Jan 23 21:29:45 2018 -0500
+++ b/mercurial/minifileset.py	Wed Jan 24 22:26:28 2018 -0500
@@ -30,7 +30,7 @@
             pl = len(p)
             f = lambda n, s: n.startswith(p) and (len(n) == pl or n[pl] == '/')
             return f
-        raise error.ParseError(_("unsupported file pattern"),
+        raise error.ParseError(_("unsupported file pattern: %s") % name,
                                hint=_('paths must be prefixed with "path:"'))
     elif op == 'or':
         func1 = _compile(tree[1])
--- a/tests/test-lfs.t	Tue Jan 23 21:29:45 2018 -0500
+++ b/tests/test-lfs.t	Wed Jan 24 22:26:28 2018 -0500
@@ -18,6 +18,10 @@
 # Commit small file
   $ echo s > smallfile
   $ echo '**.py = LF' > .hgeol
+  $ hg --config lfs.track='"size(\">1000B\")"' commit -Aqm "add small file"
+  hg: parse error: unsupported file pattern: size(">1000B")
+  (paths must be prefixed with "path:")
+  [255]
   $ hg --config lfs.track='size(">1000B")' commit -Aqm "add small file"
 
 # Commit large file