Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
tests: don't use 'test -e'
authorMads Kiilerich <mads@kiilerich.com>
Mon, 17 Oct 2011 00:11:56 +0200
changeset 15282 d4addef0ec74
parent 15272 2889d4574726
child 15283 748715a380bc
child 15368 872f06c342ff
tests: don't use 'test -e' On Solaris 10: $ test -e f test: argument expected
contrib/check-code.py file | annotate | diff | comparison | revisions
tests/test-subrepo-svn.t file | annotate | diff | comparison | revisions 
--- a/contrib/check-code.py	Sat Oct 15 14:19:24 2011 -0500
+++ b/contrib/check-code.py	Mon Oct 17 00:11:56 2011 +0200
@@ -69,6 +69,7 @@
     (r'ls\s+[^|-]+\s+-', "options to 'ls' must come before filenames"),
     (r'[^>]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
     (r'stop\(\)', "don't use 'stop' as a shell function name"),
+    (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
   ],
   # warnings
   []
--- a/tests/test-subrepo-svn.t	Sat Oct 15 14:19:24 2011 -0500
+++ b/tests/test-subrepo-svn.t	Mon Oct 17 00:11:56 2011 +0200
@@ -581,5 +581,5 @@
   A    $TESTTMP/rebaserepo/recreated/somethingold
   Checked out revision 10.
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
-  $ test -e recreated/somethingold
+  $ test -f recreated/somethingold
mercurial