Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
verify: avoid shadowing two variables with a list comprehension
authorAugie Fackler <augie@google.com>
Thu, 10 Nov 2016 16:35:54 -0500
changeset 30393 b667b78099eb
parent 30392 155d7ea98085
child 30394 046a7e828ea6
verify: avoid shadowing two variables with a list comprehension The variable names are clearly worse now, but since we're really just transposing key and value I'm not too worried about the clarity loss.
mercurial/verify.py file | annotate | diff | comparison | revisions 
--- a/mercurial/verify.py	Thu Nov 10 16:35:10 2016 -0500
+++ b/mercurial/verify.py	Thu Nov 10 16:35:54 2016 -0500
@@ -425,7 +425,7 @@
 
             # cross-check
             if f in filenodes:
-                fns = [(lr, n) for n, lr in filenodes[f].iteritems()]
+                fns = [(v, k) for k, v in filenodes[f].iteritems()]
                 for lr, node in sorted(fns):
                     self.err(lr, _("manifest refers to unknown revision %s") %
                              short(node), f)
mercurial