test: make check-py3-compat.py ignore empty code more reliably
authorYuya Nishihara <yuya@tcha.org>
Fri, 11 Mar 2016 10:26:58 +0900
changeset 28475 ae522fb493d4
parent 28474 00e6e0d0bfeb
child 28476 e28dc6de38e7
test: make check-py3-compat.py ignore empty code more reliably It couldn't exclude an empty file containing comments. That's why hgext/__init__.py had been listed in test-check-py3-compat.t before "hgext: officially turn 'hgext' into a namespace package".
contrib/check-py3-compat.py
--- a/contrib/check-py3-compat.py	Fri Mar 11 22:30:43 2016 +0800
+++ b/contrib/check-py3-compat.py	Fri Mar 11 10:26:58 2016 +0900
@@ -16,12 +16,12 @@
     """Check Python 3 compatibility for a file."""
     with open(f, 'rb') as fh:
         content = fh.read()
+    root = ast.parse(content)
 
     # Ignore empty files.
-    if not content.strip():
+    if not root.body:
         return
 
-    root = ast.parse(content)
     futures = set()
     haveprint = False
     for node in ast.walk(root):