check-code: 'printf \0' is apparently fine - accept it in check-code stable
authorMads Kiilerich <mads@kiilerich.com>
Mon, 23 Apr 2012 01:39:26 +0200
branchstable
changeset 16486 ac987a9d8d49
parent 16485 f48b075ff088
child 16487 4fe874697a4d
check-code: 'printf \0' is apparently fine - accept it in check-code Nobody complained over '\0' in test-eol.t. The too strict check becomes a problem when this check is applied to more lines.
contrib/check-code.py
--- a/contrib/check-code.py	Mon Apr 23 01:39:26 2012 +0200
+++ b/contrib/check-code.py	Mon Apr 23 01:39:26 2012 +0200
@@ -55,7 +55,7 @@
     (r'head -c', "don't use 'head -c', use 'dd'"),
     (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"),
     (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"),
-    (r'printf.*\\\d{1,3}', "don't use 'printf \NNN', use Python"),
+    (r'printf.*\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"),
     (r'printf.*\\x', "don't use printf \\x, use Python"),
     (r'\$\(.*\)', "don't use $(expr), use `expr`"),
     (r'rm -rf \*', "don't use naked rm -rf, target a directory"),