Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
hgweb: convert an assert to a ProgrammingError
authorGregory Szorc <gregory.szorc@gmail.com>
Fri, 16 Mar 2018 12:10:15 -0700
changeset 36977 a82fc3922446
parent 36976 a4a95bd7158d
child 36978 c479692690ef
hgweb: convert an assert to a ProgrammingError Because assert may get optimized away. Differential Revision: https://phab.mercurial-scm.org/D2882
mercurial/hgweb/webcommands.py file | annotate | diff | comparison | revisions 
--- a/mercurial/hgweb/webcommands.py	Fri Jan 19 18:52:50 2018 -0800
+++ b/mercurial/hgweb/webcommands.py	Fri Mar 16 12:10:15 2018 -0700
@@ -1195,7 +1195,9 @@
         web.res.headers['Content-Encoding'] = encoding
 
     web.res.setbodywillwrite()
-    assert list(web.res.sendresponse()) == []
+    if list(web.res.sendresponse()):
+        raise error.ProgrammingError('sendresponse() should not emit data '
+                                     'if writing later')
 
     bodyfh = web.res.getbodyfile()
mercurial