Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
pytype: stop excluding upgrade.py
authorMatt Harbison <matt_harbison@yahoo.com>
Sun, 12 Dec 2021 20:01:05 -0500
changeset 48472 a4d8de93023c
parent 48471 b005d07ded7d
child 48473 8843c9a8771b
pytype: stop excluding upgrade.py The sole failure here was this, which is fixed by simply creating a set like the caller, instead of a dict: File "/mnt/c/Users/Matt/hg/mercurial/upgrade.py", line 73, in upgraderepo: No attribute 'discard' on Dict[nothing, nothing] [attribute-error] In Union[Any, Dict[nothing, nothing]] Differential Revision: https://phab.mercurial-scm.org/D11911
mercurial/upgrade.py file | annotate | diff | comparison | revisions
tests/test-check-pytype.t file | annotate | diff | comparison | revisions 
--- a/mercurial/upgrade.py	Tue Dec 14 20:36:36 2021 +0100
+++ b/mercurial/upgrade.py	Sun Dec 12 20:01:05 2021 -0500
@@ -42,7 +42,7 @@
 ):
     """Upgrade a repository in place."""
     if optimize is None:
-        optimize = {}
+        optimize = set()
     repo = repo.unfiltered()
 
     specified_revlogs = {}
--- a/tests/test-check-pytype.t	Tue Dec 14 20:36:36 2021 +0100
+++ b/tests/test-check-pytype.t	Sun Dec 12 20:01:05 2021 -0500
@@ -40,7 +40,6 @@
 mercurial/testing/storage.py  # tons of [attribute-error]
 mercurial/ui.py               # [attribute-error], [wrong-arg-types]
 mercurial/unionrepo.py        # ui, svfs, unfiltered [attribute-error]
-mercurial/upgrade.py          # line 84, in upgraderepo: No attribute 'discard' on Dict[nothing, nothing] [attribute-error]
 mercurial/util.py             # [attribute-error], [wrong-arg-count]
 mercurial/utils/procutil.py   # [attribute-error], [module-attr], [bad-return-type]
 mercurial/utils/stringutil.py # [module-attr], [wrong-arg-count]
@@ -88,7 +87,6 @@
   >    -x mercurial/thirdparty \
   >    -x mercurial/ui.py \
   >    -x mercurial/unionrepo.py \
-  >    -x mercurial/upgrade.py \
   >    -x mercurial/utils/procutil.py \
   >    -x mercurial/utils/stringutil.py \
   >    -x mercurial/utils/memorytop.py \
mercurial