Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
pycompat: avoid using an extra function
authorPulkit Goyal <7895pulkit@gmail.com>
Sat, 13 Aug 2016 04:21:42 +0530
changeset 29779 997e8cf4d0a2
parent 29778 594035c1adc7
child 29780 531e85eec23c
pycompat: avoid using an extra function We have a single line function which just lowercase the letters and replaces "_" with "". Its better to avoid that function call. Moreover we calling this function around 33 times.
mercurial/pycompat.py file | annotate | diff | comparison | revisions 
--- a/mercurial/pycompat.py	Sat Aug 13 03:03:01 2016 +0530
+++ b/mercurial/pycompat.py	Sat Aug 13 04:21:42 2016 +0530
@@ -41,11 +41,10 @@
 
     copies items from origin to alias
     """
-    def hgcase(item):
-        return item.replace('_', '').lower()
     for item in items:
         try:
-            setattr(alias, hgcase(item), getattr(origin, item))
+            lcase = item.replace('_', '').lower()
+            setattr(alias, lcase, getattr(origin, item))
         except AttributeError:
             pass
mercurial