safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:37:11 +0100
changeset 50609 90945014f4e4
parent 50608 046b9cce5850
child 50610 a6a17f799839
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/templatefilters.py
--- a/mercurial/templatefilters.py	Thu Feb 02 17:37:02 2023 +0100
+++ b/mercurial/templatefilters.py	Thu Feb 02 17:37:11 2023 +0100
@@ -346,7 +346,7 @@
             for k, v in sorted(obj.items())
         ]
         return b'{' + b', '.join(out) + b'}'
-    elif util.safehasattr(obj, b'__iter__'):
+    elif util.safehasattr(obj, '__iter__'):
         out = [json(i, paranoid) for i in obj]
         return b'[' + b', '.join(out) + b']'
     raise error.ProgrammingError(b'cannot encode %r' % obj)