revset: wider definition of ascending and descending for spanset
authorPierre-Yves David <pierre-yves.david@fb.com>
Tue, 16 Sep 2014 23:34:18 -0700
changeset 22481 8488955127b0
parent 22480 dff638170c48
child 22482 2e40cda4b2c5
revset: wider definition of ascending and descending for spanset Before this patches, empty spanset were seen as neither ascending nor descending. This is mathematically wrong and create some edges case. We put `isascending` and `isdescending` back on track so we can use them to simplify some of the spanset code. Benchmarks show no performances harmed in the process.
mercurial/revset.py
--- a/mercurial/revset.py	Wed Sep 17 23:21:20 2014 +0900
+++ b/mercurial/revset.py	Tue Sep 16 23:34:18 2014 -0700
@@ -2835,10 +2835,10 @@
         return self
 
     def isascending(self):
-        return self._start < self._end
+        return self._start <= self._end
 
     def isdescending(self):
-        return self._start > self._end
+        return self._start >= self._end
 
     def filter(self, l):
         if self._start <= self._end: