Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
narrow: avoid overwriting a variable
authorMartin von Zweigbergk <martinvonz@google.com>
Tue, 02 Oct 2018 09:11:18 -0700
changeset 39985 825a636812a4
parent 39984 731961d972ba
child 39986 138e2d6d3b53
narrow: avoid overwriting a variable I don't like to overwrite variables, especially not with a different type (because it makes it harder to explain what the variable is for, and, therefore, to name it well). Differential Revision: https://phab.mercurial-scm.org/D4846
hgext/narrow/narrowbundle2.py file | annotate | diff | comparison | revisions 
--- a/hgext/narrow/narrowbundle2.py	Thu Sep 27 20:16:48 2018 -0700
+++ b/hgext/narrow/narrowbundle2.py	Tue Oct 02 09:11:18 2018 -0700
@@ -67,11 +67,10 @@
     """
     # XXX: This patch will start sending bundle2 after couple of patches when
     # called from the wireprotocol command
-    common = repo.revs("::%ln", common)
     commonnodes = set()
     cl = repo.changelog
-    for c in common:
-        commonnodes.add(cl.node(c))
+    for r in repo.revs("::%ln", common):
+        commonnodes.add(cl.node(r))
     if commonnodes:
         # XXX: we should only send the filelogs (and treemanifest). user
         # already has the changelog and manifest
mercurial