revset-limit: use boolean testing instead of `len(revs) < 1`
authorPierre-Yves David <pierre-yves.david@fb.com>
Mon, 06 Oct 2014 11:43:32 -0700
changeset 22814 8110405cf8ae
parent 22813 5a96df266b2b
child 22815 4f81470e83bf
revset-limit: use boolean testing instead of `len(revs) < 1` I'm not sure why we wrote it that way. But smartsets have faster/lazier non-zero testing than length computation.
mercurial/scmutil.py
--- a/mercurial/scmutil.py	Tue Oct 07 00:18:08 2014 -0700
+++ b/mercurial/scmutil.py	Mon Oct 06 11:43:32 2014 -0700
@@ -478,7 +478,7 @@
         return repo[default]
 
     l = revrange(repo, [revspec])
-    if len(l) < 1:
+    if not l:
         raise util.Abort(_('empty revision set'))
     return repo[l[-1]]