Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
rust: add TODO about lifetime of program_name variable
authorGregory Szorc <gregory.szorc@gmail.com>
Wed, 10 Jan 2018 19:36:45 -0800
changeset 35604 74bec9e74831
parent 35603 11c86ab69e67
child 35605 45a816361926
rust: add TODO about lifetime of program_name variable Per review comment in D1581. Differential Revision: https://phab.mercurial-scm.org/D1847
rust/hgcli/src/main.rs file | annotate | diff | comparison | revisions 
--- a/rust/hgcli/src/main.rs	Wed Jan 10 19:23:36 2018 -0800
+++ b/rust/hgcli/src/main.rs	Wed Jan 10 19:36:45 2018 -0800
@@ -125,6 +125,9 @@
     // Set program name. The backing memory needs to live for the duration of the
     // interpreter.
     //
+    // TODO consider storing this in a static or associating with lifetime of
+    // the Python interpreter.
+    //
     // Yes, we use the path to the Python interpreter not argv[0] here. The
     // reason is because Python uses the given path to find the location of
     // Python files. Apparently we could define our own ``Py_GetPath()``
mercurial