hghave: disallow symlinks on Windows
authorMatt Harbison <matt_harbison@yahoo.com>
Tue, 05 Nov 2019 18:32:00 -0500
changeset 43455 6792da448437
parent 43454 c8e5b3094a1d
child 43456 ab9b0a20b9e6
hghave: disallow symlinks on Windows Symlinks on Windows require either a special priviledge, or enabling Developer Mode. It's probably the latter that is enabled on the new CI machine. But since Mercurial itself is saying no to symlinks on Windows, the tests for symlinks shouldn't be attempted. This should fix a lot of the noise in the py3 tests. Differential Revision: https://phab.mercurial-scm.org/D7233
tests/hghave.py
--- a/tests/hghave.py	Tue Nov 05 15:00:44 2019 -0800
+++ b/tests/hghave.py	Tue Nov 05 18:32:00 2019 -0500
@@ -431,7 +431,8 @@
 
 @check("symlink", "symbolic links")
 def has_symlink():
-    if getattr(os, "symlink", None) is None:
+    # mercurial.windows.checklink() is a hard 'no' at the moment
+    if os.name == 'nt' or getattr(os, "symlink", None) is None:
         return False
     name = tempfile.mktemp(dir='.', prefix=tempprefix)
     try: