narrowrevlog: add a TODO around remotefilelog moving to core
authorAugie Fackler <augie@google.com>
Mon, 12 Feb 2018 14:15:52 -0500
changeset 36097 66b4ffe90676
parent 36096 48b592d986e7
child 36098 9c55bbc29dcf
narrowrevlog: add a TODO around remotefilelog moving to core We should clean this up considerably when remotefilelog lands, which we expect to try and accomplish in the near-ish future. Differential Revision: https://phab.mercurial-scm.org/D2189
hgext/narrow/narrowrevlog.py
--- a/hgext/narrow/narrowrevlog.py	Mon Feb 12 14:12:28 2018 -0500
+++ b/hgext/narrow/narrowrevlog.py	Mon Feb 12 14:15:52 2018 -0500
@@ -156,6 +156,10 @@
             # rename-checking logic when on remotefilelog. This
             # might be incorrect on other non-revlog-based storage
             # engines, but for now this seems to be fine.
+            #
+            # TODO: when remotefilelog is in core, improve this to
+            # explicitly look for remotefilelog instead of cheating
+            # with a hasattr check.
             if util.safehasattr(self, 'node'):
                 node = self.node(rev)
                 # Because renamed() is overridden above to