Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
convert: subversion should use util.quotecommand to wrap args to popen2
authorSteve Borho <steve@borho.org>
Wed, 22 Dec 2010 13:25:00 -0600
changeset 13190 5314cbb775f6
parent 13189 f5be619663f9
child 13191 1aea66b71f4f
convert: subversion should use util.quotecommand to wrap args to popen2 All other callers of util.popen2 and util.popen3 do this, as well as direct callers of subprocess.Popen.
hgext/convert/subversion.py file | annotate | diff | comparison | revisions 
--- a/hgext/convert/subversion.py	Thu Dec 23 13:23:20 2010 -0600
+++ b/hgext/convert/subversion.py	Wed Dec 22 13:25:00 2010 -0600
@@ -914,7 +914,7 @@
         arg = encodeargs(args)
         hgexe = util.hgexecutable()
         cmd = '%s debugsvnlog' % util.shellquote(hgexe)
-        stdin, stdout = util.popen2(cmd)
+        stdin, stdout = util.popen2(util.quotecommand(cmd))
         stdin.write(arg)
         try:
             stdin.close()
mercurial