url: replace uses of hasattr with safehasattr or getattr
authorAugie Fackler <durin42@gmail.com>
Mon, 25 Jul 2011 15:55:51 -0500
changeset 14964 376c32a5ccdc
parent 14963 c035f1c53e39
child 14965 194b043dfa51
url: replace uses of hasattr with safehasattr or getattr
mercurial/url.py
--- a/mercurial/url.py	Mon Jul 25 15:53:22 2011 -0500
+++ b/mercurial/url.py	Mon Jul 25 15:55:51 2011 -0500
@@ -129,7 +129,7 @@
             orgsend(self, data)
     return _sendfile
 
-has_https = hasattr(urllib2, 'HTTPSHandler')
+has_https = util.safehasattr(urllib2, 'HTTPSHandler')
 if has_https:
     try:
         _create_connection = socket.create_connection
@@ -186,8 +186,8 @@
 # general transaction handler to support different ways to handle
 # HTTPS proxying before and after Python 2.6.3.
 def _generic_start_transaction(handler, h, req):
-    if hasattr(req, '_tunnel_host') and req._tunnel_host:
-        tunnel_host = req._tunnel_host
+    tunnel_host = getattr(req, '_tunnel_host', None)
+    if tunnel_host:
         if tunnel_host[:7] not in ['http://', 'https:/']:
             tunnel_host = 'https://' + tunnel_host
         new_tunnel = True