Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:24:05 +0100
changeset 50572 35e420abaef3
parent 50571 dbd57239acb8
child 50573 9a322ccd2fdc
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/dispatch.py file | annotate | diff | comparison | revisions 
--- a/mercurial/dispatch.py	Thu Feb 02 17:23:55 2023 +0100
+++ b/mercurial/dispatch.py	Thu Feb 02 17:24:05 2023 +0100
@@ -734,7 +734,7 @@
             self.name,
             self.definition,
         )
-        if util.safehasattr(self, b'shell'):
+        if util.safehasattr(self, 'shell'):
             return self.fn(ui, *args, **opts)
         else:
             try:
mercurial