Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
color: minor reversal of two conditional clause for clarity
authorPierre-Yves David <pierre-yves.david@ens-lyon.org>
Thu, 22 Dec 2016 13:19:12 +0100
changeset 31071 350d737e059d
parent 31070 ebd14a4b03fc
child 31072 80f04ba7f4d1
color: minor reversal of two conditional clause for clarity Another minor cleanup while reading the code. The two branches of the conditional have similar complexity so we go for the order that give us the simplest condition (we drop the negation).
mercurial/color.py file | annotate | diff | comparison | revisions 
--- a/mercurial/color.py	Thu Feb 16 10:52:27 2017 +0100
+++ b/mercurial/color.py	Thu Dec 22 13:19:12 2016 +0100
@@ -165,14 +165,14 @@
     'Wrap text in commands to turn on each effect.'
     if not text:
         return text
-    if not _terminfo_params:
+    if _terminfo_params:
+        start = ''.join(_effect_str(effect)
+                        for effect in ['none'] + effects.split())
+        stop = _effect_str('none')
+    else:
         start = [str(_effects[e]) for e in ['none'] + effects.split()]
         start = '\033[' + ';'.join(start) + 'm'
         stop = '\033[' + str(_effects['none']) + 'm'
-    else:
-        start = ''.join(_effect_str(effect)
-                        for effect in ['none'] + effects.split())
-        stop = _effect_str('none')
     return ''.join([start, text, stop])
 
 w32effects = None
mercurial