log: add TODO comments about --line-range processing
authorYuya Nishihara <yuya@tcha.org>
Sun, 21 Jan 2018 17:04:42 +0900
changeset 36199 2d6e03a28c31
parent 36198 7bc10d3f68b4
child 36200 deb851914fd7
log: add TODO comments about --line-range processing
mercurial/commands.py
--- a/mercurial/commands.py	Sun Jan 21 16:15:20 2018 +0900
+++ b/mercurial/commands.py	Sun Jan 21 17:04:42 2018 +0900
@@ -3414,6 +3414,7 @@
         raise error.Abort(_('--line-range requires --follow'))
 
     if linerange and pats:
+        # TODO: take pats as patterns with no line-range filter
         raise error.Abort(
             _('FILE arguments are not compatible with --line-range option')
         )
@@ -3421,6 +3422,8 @@
     repo = scmutil.unhidehashlikerevs(repo, opts.get('rev'), 'nowarn')
     revs, differ = logcmdutil.getrevs(repo, pats, opts)
     if linerange:
+        # TODO: should follow file history from logcmdutil._initialrevs(),
+        # then filter the result by logcmdutil._makerevset() and --limit
         revs, differ = logcmdutil.getlinerangerevs(repo, revs, opts)
 
     getrenamed = None