contrib: improve check-code ban on $LOCALIP in output without (glob)
authorAugie Fackler <augie@google.com>
Wed, 29 Nov 2017 17:06:45 -0500
changeset 35153 273907306a39
parent 35152 c1b94f34a11a
child 35154 4c04fd032af6
contrib: improve check-code ban on $LOCALIP in output without (glob) Differential Revision: https://phab.mercurial-scm.org/D1553
contrib/check-code.py
--- a/contrib/check-code.py	Wed Nov 29 17:05:51 2017 -0500
+++ b/contrib/check-code.py	Wed Nov 29 17:06:45 2017 -0500
@@ -197,7 +197,7 @@
      'write "file:/*/$TESTTMP" + (glob) to match on windows too'),
     (r'^  [^$>].*27\.0\.0\.1',
      'use $LOCALIP not an explicit loopback address'),
-    (r'^  [^$>].*\$LOCALIP.*[^)]$',
+    (r'^  (?![>$] ).*\$LOCALIP.*[^)]$',
      'mark $LOCALIP output lines with (glob) to help tests in BSD jails'),
     (r'^  (cat|find): .*: No such file or directory',
      'use test -f to test for file existence'),