bookmarks: guard against listing bookmarks on unsupported repos stable
authorMartin Geisler <mg@lazybytes.net>
Mon, 23 Aug 2010 22:16:56 +0200
branchstable
changeset 12026 1938954354ec
parent 12009 b20211b307b3
child 12027 e1a3d7ed478e
child 12028 21984c1c83d4
bookmarks: guard against listing bookmarks on unsupported repos This fixes clones and pulls from statichttprepository repos.
hgext/bookmarks.py
--- a/hgext/bookmarks.py	Sat Aug 21 10:44:57 2010 -0500
+++ b/hgext/bookmarks.py	Mon Aug 23 22:16:56 2010 +0200
@@ -370,6 +370,11 @@
     repo.__class__ = bookmark_repo
 
 def listbookmarks(repo):
+    # We may try to list bookmarks on a repo type that does not
+    # support it (e.g., statichttprepository).
+    if not hasattr(repo, '_bookmarks'):
+        return {}
+
     d = {}
     for k, v in repo._bookmarks.iteritems():
         d[k] = hex(v)