Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: check for argument passing py2.6ism
authorMatt Mackall <mpm@selenic.com>
Wed, 19 Mar 2014 18:04:03 -0500
changeset 20796 131f7fe06e9e
parent 20795 29b159bd71bc
child 20797 e286ab22e461
check-code: check for argument passing py2.6ism
contrib/check-code.py file | annotate | diff | comparison | revisions
mercurial/dispatch.py file | annotate | diff | comparison | revisions 
--- a/contrib/check-code.py	Wed Mar 19 16:21:53 2014 -0500
+++ b/contrib/check-code.py	Wed Mar 19 18:04:03 2014 -0500
@@ -191,6 +191,7 @@
 
 pypats = [
   [
+    (r'\([^)]*\*\w[^()]+\w+=', "can't pass varargs with keyword in Py2.5"),
     (r'^\s*def\s*\w+\s*\(.*,\s*\(',
      "tuple parameter unpacking not available in Python 3+"),
     (r'lambda\s*\(.*,.*\)',
--- a/mercurial/dispatch.py	Wed Mar 19 16:21:53 2014 -0500
+++ b/mercurial/dispatch.py	Wed Mar 19 18:04:03 2014 -0500
@@ -103,8 +103,8 @@
             if req.repo:
                 # copy configs that were passed on the cmdline (--config) to
                 # the repo ui
-                for cfg in cfgs:
-                    req.repo.ui.setconfig(*cfg, source='--config')
+                for sec, name, val in cfgs:
+                    req.repo.ui.setconfig(sec, name, val, source='--config')
 
             # if we are in HGPLAIN mode, then disable custom debugging
             debugger = ui.config("ui", "debugger")
mercurial