dirstate: avoid use of zip on big lists
authorBryan O'Sullivan <bryano@fb.com>
Fri, 30 Nov 2012 15:55:08 -0800
changeset 18018 0fed3fe45ea7
parent 18017 74912fe3d718
child 18019 e248bff2d8dd
dirstate: avoid use of zip on big lists In a clean working directory containing 170,000 tracked files, this improves performance of "hg --time diff" from 1.69 seconds to 1.43. This idea is due to Siddharth Agarwal.
mercurial/dirstate.py
--- a/mercurial/dirstate.py	Fri Nov 30 15:55:07 2012 -0800
+++ b/mercurial/dirstate.py	Fri Nov 30 15:55:08 2012 -0800
@@ -696,8 +696,9 @@
         # step 3: report unseen items in the dmap hash
         if not skipstep3 and not exact:
             visit = sorted([f for f in dmap if f not in results and matchfn(f)])
-            for nf, st in zip(visit, util.statfiles([join(i) for i in visit])):
-                results[nf] = st
+            nf = iter(visit).next
+            for st in util.statfiles([join(i) for i in visit]):
+                results[nf()] = st
         for s in subrepos:
             del results[s]
         del results['.hg']