# HG changeset patch # User Simon Heimberg # Date 1372654258 -7200 # Node ID ee07f9d142c9960b4d9c62b852a2d05b5be2681d # Parent 83d0df2ddf3f2a07ed347afcfa30ddacc18b4c3d check-code: do not warn on printf \\x or \\[1-9] When there is a double backslash the following char does not have any special meaning. So do not warn on this. Remove the now obsolete no-check-code statement. (It was used wrongly anyway, it skipped checking the entire file.) diff -r 83d0df2ddf3f -r ee07f9d142c9 contrib/check-code.py --- a/contrib/check-code.py Tue Nov 06 00:22:56 2012 +0100 +++ b/contrib/check-code.py Mon Jul 01 06:50:58 2013 +0200 @@ -68,8 +68,8 @@ (r'head -c', "don't use 'head -c', use 'dd'"), (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"), (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"), - (r'printf.*\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"), - (r'printf.*\\x', "don't use printf \\x, use Python"), + (r'printf.*[^\\]\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"), + (r'printf.*[^\\]\\x', "don't use printf \\x, use Python"), (r'\$\(.*\)', "don't use $(expr), use `expr`"), (r'rm -rf \*', "don't use naked rm -rf, target a directory"), (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w', diff -r 83d0df2ddf3f -r ee07f9d142c9 tests/test-subrepo-paths.t --- a/tests/test-subrepo-paths.t Tue Nov 06 00:22:56 2012 +0100 +++ b/tests/test-subrepo-paths.t Mon Jul 01 06:50:58 2013 +0200 @@ -17,7 +17,7 @@ hg debugsub with remapping $ echo '[subpaths]' >> .hg/hgrc - $ printf 'http://example.net/lib(.*) = C:\\libs\\\\1-lib\\\n' >> .hg/hgrc # no-check-code + $ printf 'http://example.net/lib(.*) = C:\\libs\\\\1-lib\\\n' >> .hg/hgrc $ hg debugsub path sub