# HG changeset patch # User Bryan O'Sullivan # Date 1452892487 28800 # Node ID ed59ae8b025e35c1c7f4f29e91ecaec898bf8326 # Parent b2145c195f24a545a2f7051e5830c7ebb40734da with: use context manager for transaction in mercurial_sink diff -r b2145c195f24 -r ed59ae8b025e hgext/convert/hg.py --- a/hgext/convert/hg.py Fri Jan 15 13:14:47 2016 -0800 +++ b/hgext/convert/hg.py Fri Jan 15 13:14:47 2016 -0800 @@ -323,9 +323,7 @@ self.repo.ui.setconfig('phases', 'new-commit', phases.phasenames[commit.phase], 'convert') - tr = self.repo.transaction("convert") - - try: + with self.repo.transaction("convert") as tr: node = hex(self.repo.commitctx(ctx)) # If the node value has changed, but the phase is lower than @@ -336,9 +334,6 @@ if ctx.phase() < phases.draft: phases.retractboundary(self.repo, tr, phases.draft, [ctx.node()]) - tr.close() - finally: - tr.release() text = "(octopus merge fixup)\n" p2 = node