# HG changeset patch # User Martin von Zweigbergk # Date 1496175392 25200 # Node ID e4d0b2efb8b5aea10d1880d602c7d7b3a32c25a3 # Parent c37ca35b845071fafe6de43172ab6c7c129a2ab5 hidden: remove unnecessary guard condition The "if visible" guard is now pretty pointless, because the function call it guards will do almost no work anyway when there are no visible revisions. We can also stop wrapping "visible" in a set since it just needs to be an iterable now. diff -r c37ca35b8450 -r e4d0b2efb8b5 mercurial/repoview.py --- a/mercurial/repoview.py Tue May 30 10:27:20 2017 -0700 +++ b/mercurial/repoview.py Tue May 30 13:16:32 2017 -0700 @@ -76,9 +76,8 @@ mutablephases = (phases.draft, phases.secret) mutable = repo._phasecache.getrevset(repo, mutablephases) - visible = set(mutable - hidden) - if visible: - _revealancestors(pfunc, hidden, visible) + visible = mutable - hidden + _revealancestors(pfunc, hidden, visible) return frozenset(hidden) def computeunserved(repo):