# HG changeset patch # User Mads Kiilerich # Date 1322183388 -3600 # Node ID e387e760b207383c961ed8accd35583791a33bb0 # Parent 4a4a95029b317f2adb84744494a6d6ffebab29b1 largefiles: avoid use of uinitialized variable in case of errors diff -r 4a4a95029b31 -r e387e760b207 hgext/largefiles/overrides.py --- a/hgext/largefiles/overrides.py Fri Nov 25 02:09:45 2011 +0100 +++ b/hgext/largefiles/overrides.py Fri Nov 25 02:09:48 2011 +0100 @@ -619,11 +619,13 @@ f = lfutil.splitstandin(f) def getdatafn(): + fd = None try: fd = open(path, 'rb') return fd.read() finally: - fd.close() + if fd: + fd.close() getdata = getdatafn write(f, 'x' in ff and 0755 or 0644, 'l' in ff, getdata)