# HG changeset patch
# User Jun Wu <quark@fb.com>
# Date 1480533784 0
# Node ID cbeb54ec0481a4bf9723ba4b80a5861a813c8531
# Parent  c059286a0f9c4079515bbc5a9e2320ed63912c9c
check-code: add a rule to forbid "cp -r"

See the commit message of the previous patch for the reason. In short,
according to the current POSIX standard, "-r" is "removed", and "-R" is the
current standard way to do "copy file hierarchies".

diff -r c059286a0f9c -r cbeb54ec0481 contrib/check-code.py
--- a/contrib/check-code.py	Wed Nov 30 19:25:18 2016 +0000
+++ b/contrib/check-code.py	Wed Nov 30 19:23:04 2016 +0000
@@ -142,7 +142,8 @@
     (r'\|&', "don't use |&, use 2>&1"),
     (r'\w =  +\w', "only one space after = allowed"),
     (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),
-    (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'")
+    (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
+    (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
   ],
   # warnings
   [