# HG changeset patch # User Martin von Zweigbergk # Date 1418363929 28800 # Node ID b46b9865dd0843861e5e0ba541f0c2728f686738 # Parent 35c7249031576a6398b853975f23ac25e88dbe63 merge: let _forgetremoved() work on the file->action dict By moving the conversion from the file->action dict after _forgetremoved(), we make that method shorter by removing the need for the confusing 'xactions' variable. diff -r 35c724903157 -r b46b9865dd08 mercurial/merge.py --- a/mercurial/merge.py Thu Dec 11 21:06:16 2014 -0800 +++ b/mercurial/merge.py Thu Dec 11 21:58:49 2014 -0800 @@ -318,20 +318,20 @@ as removed. """ - ractions = [] - factions = xactions = [] + actions = {} + m = 'f' if branchmerge: - xactions = ractions + m = 'r' for f in wctx.deleted(): if f not in mctx: - xactions.append((f, None, "forget deleted")) + actions[f] = m, None, "forget deleted" if not branchmerge: for f in wctx.removed(): if f not in mctx: - factions.append((f, None, "forget removed")) + actions[f] = 'f', None, "forget removed" - return ractions, factions + return actions def _checkcollision(repo, wmf, actions): # build provisional merged manifest up @@ -617,17 +617,16 @@ _resolvetrivial(repo, wctx, mctx, ancestors[0], actions) + if wctx.rev() is None: + fractions = _forgetremoved(wctx, mctx, branchmerge) + actions.update(fractions) + # Convert to dictionary-of-lists format actionbyfile = actions actions = dict((m, []) for m in 'a f g cd dc r dm dg m e k'.split()) for f, (m, args, msg) in actionbyfile.iteritems(): actions[m].append((f, args, msg)) - if wctx.rev() is None: - ractions, factions = _forgetremoved(wctx, mctx, branchmerge) - actions['r'].extend(ractions) - actions['f'].extend(factions) - return actions, diverge, renamedelete def batchremove(repo, actions):