# HG changeset patch # User Augie Fackler # Date 1496021398 14400 # Node ID aa333c1982abfe12a3940811d07468a286de93db # Parent 260a6f715bd212c66d9da637192f30eb4c133fc4 manifest: use itertools.chain() instead of + for Python 3 compat This is all pure-Python code, so I'm not too worried about perf here, but we can come back and fix it should it be a problem. With this change, the manifest code passes most unit tests on Python 3 (once the tests are corrected with many b prefixes. I've got a little more to sort out there and then I'll mail that change too. diff -r 260a6f715bd2 -r aa333c1982ab mercurial/manifest.py --- a/mercurial/manifest.py Sun May 28 21:29:15 2017 -0400 +++ b/mercurial/manifest.py Sun May 28 21:29:58 2017 -0400 @@ -8,6 +8,7 @@ from __future__ import absolute_import import heapq +import itertools import os import struct @@ -779,7 +780,8 @@ def iterentries(self): self._load() - for p, n in sorted(self._dirs.items() + self._files.items()): + for p, n in sorted(itertools.chain(self._dirs.items(), + self._files.items())): if p in self._files: yield self._subpath(p), n, self._flags.get(p, '') else: @@ -788,7 +790,8 @@ def iteritems(self): self._load() - for p, n in sorted(self._dirs.items() + self._files.items()): + for p, n in sorted(itertools.chain(self._dirs.items(), + self._files.items())): if p in self._files: yield self._subpath(p), n else: @@ -797,7 +800,7 @@ def iterkeys(self): self._load() - for p in sorted(self._dirs.keys() + self._files.keys()): + for p in sorted(itertools.chain(self._dirs, self._files)): if p in self._files: yield self._subpath(p) else: