# HG changeset patch
# User Valentin Gatien-Baron <vgatien-baron@janestreet.com>
# Date 1537907558 14400
# Node ID 823f34acfd46eb74d362e819d1cc3475bf05bf2f
# Parent  84c61c1593c4d6f984312832341d86e695b87867
revset: make heads(commonancestors(x + x^)) be x^, not x

Differential Revision: https://phab.mercurial-scm.org/D4742

diff -r 84c61c1593c4 -r 823f34acfd46 mercurial/revset.py
--- a/mercurial/revset.py	Tue Sep 25 16:29:39 2018 -0400
+++ b/mercurial/revset.py	Tue Sep 25 16:32:38 2018 -0400
@@ -614,11 +614,11 @@
     # This is an internal method is for quickly calculating "heads(::x and
     # ::y)"
 
-    # These greatest common ancestors are the same ones that the consesus bid
+    # These greatest common ancestors are the same ones that the consensus bid
     # merge will find.
-    h = heads(repo, fullreposet(repo), x, anyorder)
+    startrevs = getset(repo, fullreposet(repo), x, order=anyorder)
 
-    ancs = repo.changelog._commonancestorsheads(*list(h))
+    ancs = repo.changelog._commonancestorsheads(*list(startrevs))
     return subset & baseset(ancs)
 
 @predicate('commonancestors(set)', safe=True)
diff -r 84c61c1593c4 -r 823f34acfd46 tests/test-revset.t
--- a/tests/test-revset.t	Tue Sep 25 16:29:39 2018 -0400
+++ b/tests/test-revset.t	Tue Sep 25 16:32:38 2018 -0400
@@ -1080,7 +1080,7 @@
   $ hg log -T '{rev}\n' -r 'heads(commonancestors(9))'
   9
   $ hg log -T '{rev}\n' -r 'heads(commonancestors(8 + 9))'
-  9
+  8
 
 test ancestor variants of empty revision