# HG changeset patch # User Pierre-Yves David # Date 1606776749 -3600 # Node ID 8037d064114681320b33698c18bcebf7aa6feba1 # Parent 9dd5b129ff288b9ffc3713a738117ff071f223f7 upgrade: capitalize the `deficiency` constant I am reworking this code and moving to the current naming scheme help readability. Differential Revision: https://phab.mercurial-scm.org/D9473 diff -r 9dd5b129ff28 -r 8037d0641146 mercurial/upgrade.py --- a/mercurial/upgrade.py Mon Nov 30 09:47:46 2020 -0800 +++ b/mercurial/upgrade.py Mon Nov 30 23:52:29 2020 +0100 @@ -151,7 +151,7 @@ return set() -deficiency = b'deficiency' +DEFICIENCY = b'deficiency' optimisation = b'optimization' @@ -165,13 +165,13 @@ will be mapped to an action later in the upgrade process. type - Either ``deficiency`` or ``optimisation``. A deficiency is an obvious + Either ``DEFICIENCY`` or ``optimisation``. A deficiency is an obvious problem. An optimization is an action (sometimes optional) that can be taken to further improve the state of the repository. description Message intended for humans explaining the improvement in more detail, - including the implications of it. For ``deficiency`` types, should be + including the implications of it. For ``DEFICIENCY`` types, should be worded in the present tense. For ``optimisation`` types, should be worded in the future tense. @@ -210,7 +210,7 @@ class formatvariant(improvement): """an improvement subclass dedicated to repository format""" - type = deficiency + type = DEFICIENCY ### The following attributes should be defined for each class: # machine-readable string uniquely identifying this improvement. it will be @@ -218,7 +218,7 @@ name = None # message intended for humans explaining the improvement in more detail, - # including the implications of it ``deficiency`` types, should be worded + # including the implications of it ``DEFICIENCY`` types, should be worded # in the present tense. description = None