# HG changeset patch
# User Matt Mackall <mpm@selenic.com>
# Date 1332882839 18000
# Node ID 795d591b6ef5deddc102c8b0ec27fb6c5376131b
# Parent  bc1d949261c4a5e7f30fbaddb002bf82ef6b1f27
alias: abort on missing positional args (issue3331)

diff -r bc1d949261c4 -r 795d591b6ef5 mercurial/dispatch.py
--- a/mercurial/dispatch.py	Wed Feb 15 17:30:21 2012 -0500
+++ b/mercurial/dispatch.py	Tue Mar 27 16:13:59 2012 -0500
@@ -218,7 +218,7 @@
 
 def aliasargs(fn, givenargs):
     args = getattr(fn, 'args', [])
-    if args and givenargs:
+    if args:
         cmd = ' '.join(map(util.shellquote, args))
 
         nums = []
@@ -227,7 +227,7 @@
             nums.append(num)
             if num < len(givenargs):
                 return givenargs[num]
-            return ''
+            raise util.Abort(_('too few arguments for command alias'))
         cmd = re.sub(r'\$(\d+|\$)', replacer, cmd)
         givenargs = [x for i, x in enumerate(givenargs)
                      if i not in nums]
diff -r bc1d949261c4 -r 795d591b6ef5 tests/test-alias.t
--- a/tests/test-alias.t	Wed Feb 15 17:30:21 2012 -0500
+++ b/tests/test-alias.t	Tue Mar 27 16:13:59 2012 -0500
@@ -134,6 +134,12 @@
 
 positional arguments
 
+  $ hg positional
+  abort: too few arguments for command alias
+  [255]
+  $ hg positional a
+  abort: too few arguments for command alias
+  [255]
   $ hg positional 'node|short' rev
   0 e63c23eaa88a | 1970-01-01 00:00 +0000