# HG changeset patch # User Yuya Nishihara # Date 1525487643 -32400 # Node ID 6e2259847f5ff2f49d80bed33646f80c6a99c926 # Parent 8256962e798c29fd398a05b70edab84ea39db857 bookmarks: extract function that looks up bookmark names by node diff -r 8256962e798c -r 6e2259847f5f mercurial/bookmarks.py --- a/mercurial/bookmarks.py Sat May 05 11:21:41 2018 +0900 +++ b/mercurial/bookmarks.py Sat May 05 11:34:03 2018 +0900 @@ -138,6 +138,14 @@ self._clean = False del self._refmap[key] + def names(self, node): + """Return a sorted list of bookmarks pointing to the specified node""" + marks = [] + for m, n in self._refmap.iteritems(): + if n == node: + marks.append(m) + return sorted(marks) + def changectx(self, mark): node = self._refmap[mark] return self._repo[node] diff -r 8256962e798c -r 6e2259847f5f mercurial/localrepo.py --- a/mercurial/localrepo.py Sat May 05 11:21:41 2018 +0900 +++ b/mercurial/localrepo.py Sat May 05 11:34:03 2018 +0900 @@ -1029,11 +1029,7 @@ def nodebookmarks(self, node): """return the list of bookmarks pointing to the specified node""" - marks = [] - for bookmark, n in self._bookmarks.iteritems(): - if n == node: - marks.append(bookmark) - return sorted(marks) + return self._bookmarks.names(node) def branchmap(self): '''returns a dictionary {branch: [branchheads]} with branchheads