# HG changeset patch # User Boris Feld # Date 1517848487 -3600 # Node ID 69cf2e422490494938f3bbe37060fdc3c16a0831 # Parent 1f2b8a644dd4db209eecf6a36bc7dc0a7ad972a7 revlog: use context manager for data file lifetime in checkinlinesize This is clearer, safer and more modern. diff -r 1f2b8a644dd4 -r 69cf2e422490 mercurial/revlog.py --- a/mercurial/revlog.py Mon Feb 05 17:34:19 2018 +0100 +++ b/mercurial/revlog.py Mon Feb 05 17:34:47 2018 +0100 @@ -1859,12 +1859,9 @@ fp.flush() fp.close() - df = self._datafp('w') - try: + with self._datafp('w') as df: for r in self: df.write(self._getsegmentforrevs(r, r)[1]) - finally: - df.close() fp = self._indexfp('w') self.version &= ~FLAG_INLINE_DATA