# HG changeset patch # User David Soria Parra # Date 1390500506 -3600 # Node ID 40f08c31844c69891c25e2849c9aaace3b841a76 # Parent 4dd91c466a816b59b8ce7c83f094a7e7ef92bdcc parsers: fix 'unsigned expression is always true' warning (issue4142) On Mac OS gcc-llvm throws an -Wtautological-compare warning because flen is defined as an unsigned integer, therefore flen < 0 is always true. diff -r 4dd91c466a81 -r 40f08c31844c mercurial/parsers.c --- a/mercurial/parsers.c Thu Jan 23 14:06:15 2014 -0600 +++ b/mercurial/parsers.c Thu Jan 23 19:08:26 2014 +0100 @@ -185,7 +185,7 @@ flen = getbe32(cur + 13); pos += 17; cur += 17; - if (flen > len - pos || flen < 0) { + if (flen > len - pos) { PyErr_SetString(PyExc_ValueError, "overflow in dirstate"); goto quit; }