# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1499710203 -7200
# Node ID 3325c7dcabaaa17572a9b913e9821bd01bbc17af
# Parent  169c97bbd94c3f22b9b89b32e008ab8492f11c71
bookmark: deprecate 'recordchange' in favor of 'applychanges'

Now that we have migrated all in-core caller of 'recordchange' to
'applychanges', deprecate 'recordchange' so external callers will move to the
new unified method.

diff -r 169c97bbd94c -r 3325c7dcabaa hgext/share.py
--- a/hgext/share.py	Mon Jul 10 20:06:15 2017 +0200
+++ b/hgext/share.py	Mon Jul 10 20:10:03 2017 +0200
@@ -141,7 +141,7 @@
 
 def extsetup(ui):
     extensions.wrapfunction(bookmarks, '_getbkfile', getbkfile)
-    extensions.wrapfunction(bookmarks.bmstore, 'recordchange', recordchange)
+    extensions.wrapfunction(bookmarks.bmstore, '_recordchange', recordchange)
     extensions.wrapfunction(bookmarks.bmstore, '_writerepo', writerepo)
     extensions.wrapcommand(commands.table, 'clone', clone)
 
diff -r 169c97bbd94c -r 3325c7dcabaa mercurial/bookmarks.py
--- a/mercurial/bookmarks.py	Mon Jul 10 20:06:15 2017 +0200
+++ b/mercurial/bookmarks.py	Mon Jul 10 20:10:03 2017 +0200
@@ -117,9 +117,15 @@
                 del self[name]
             else:
                 self[name] = node
-        self.recordchange(tr)
+        self._recordchange(tr)
 
     def recordchange(self, tr):
+        msg = ("'bookmarks.recorchange' is deprecated, "
+               "use 'bookmarks.applychanges'")
+        self._repo.ui.deprecwarn(msg, '4.3')
+        return self._recordchange(tr)
+
+    def _recordchange(self, tr):
         """record that bookmarks have been changed in a transaction
 
         The transaction is then responsible for updating the file content."""
diff -r 169c97bbd94c -r 3325c7dcabaa tests/test-obsolete.t
--- a/tests/test-obsolete.t	Mon Jul 10 20:06:15 2017 +0200
+++ b/tests/test-obsolete.t	Mon Jul 10 20:10:03 2017 +0200
@@ -1149,7 +1149,7 @@
   >  bkmstoreinst._repo.currenttransaction().addpostclose('test_extension', trhook)
   >  orig(bkmstoreinst, *args, **kwargs)
   > def extsetup(ui):
-  >   extensions.wrapfunction(bookmarks.bmstore, 'recordchange',
+  >   extensions.wrapfunction(bookmarks.bmstore, '_recordchange',
   >                           _bookmarkchanged)
   > EOF