# HG changeset patch # User Pierre-Yves David # Date 1675355747 -3600 # Node ID 1d937e495cd0ccbf22b117b6c1f293e7759e284d # Parent 921a72735482e30f574f7af09a2a6cc538b3913f safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage. diff -r 921a72735482 -r 1d937e495cd0 mercurial/smartset.py --- a/mercurial/smartset.py Thu Feb 02 17:35:38 2023 +0100 +++ b/mercurial/smartset.py Thu Feb 02 17:35:47 2023 +0100 @@ -1127,7 +1127,7 @@ This boldly assumes the other contains valid revs only. """ # other not a smartset, make is so - if not util.safehasattr(other, b'isascending'): + if not util.safehasattr(other, 'isascending'): # filter out hidden revision # (this boldly assumes all smartset are pure) #