# HG changeset patch # User Gregory Szorc # Date 1482427607 28800 # Node ID 1404146157d995dbb154473647c82762ba1c7d74 # Parent c49be208ae34e4437e3e808f9e4b2d68916f4834 convert: don't use {} as default argument value This is a common Python gotcha. I'm kinda surprised we don't have a check-code to detect this :/ diff -r c49be208ae34 -r 1404146157d9 hgext/convert/common.py --- a/hgext/convert/common.py Thu Dec 22 19:08:38 2016 -0500 +++ b/hgext/convert/common.py Thu Dec 22 09:26:47 2016 -0800 @@ -55,7 +55,7 @@ class commit(object): def __init__(self, author, date, desc, parents, branch=None, rev=None, - extra={}, sortkey=None, saverev=True, phase=phases.draft, + extra=None, sortkey=None, saverev=True, phase=phases.draft, optparents=None): self.author = author or 'unknown' self.date = date or '0 0' @@ -64,7 +64,7 @@ self.optparents = optparents or [] # will be used if already converted self.branch = branch self.rev = rev - self.extra = extra + self.extra = extra or {} self.sortkey = sortkey self.saverev = saverev self.phase = phase