# HG changeset patch
# User Patrick Mezard <patrick@mezard.eu>
# Date 1333876496 -7200
# Node ID 03e408a122c40ce974d648f5c05177676adfbc72
# Parent  c3fd35f88fbbf0c94aff8d81ffc830950b41fdaf
revset: avoid set duplication in roots()

diff -r c3fd35f88fbb -r 03e408a122c4 mercurial/revset.py
--- a/mercurial/revset.py	Sun Apr 08 11:13:06 2012 +0200
+++ b/mercurial/revset.py	Sun Apr 08 11:14:56 2012 +0200
@@ -323,13 +323,12 @@
                     break
     return s
 
-def _children(repo, narrow, s):
+def _children(repo, narrow, parentset):
     cs = set()
     pr = repo.changelog.parentrevs
-    s = set(s)
     for r in narrow:
         for p in pr(r):
-            if p in s:
+            if p in parentset:
                 cs.add(r)
     return cs
 
@@ -337,7 +336,7 @@
     """``children(set)``
     Child changesets of changesets in set.
     """
-    s = getset(repo, range(len(repo)), x)
+    s = set(getset(repo, range(len(repo)), x))
     cs = _children(repo, subset, s)
     return [r for r in subset if r in cs]