Sat, 02 Aug 2014 13:07:01 -0700 revert: add a message to noop action
Pierre-Yves David <pierre-yves.david@fb.com> [Sat, 02 Aug 2014 13:07:01 -0700] rev 22234
revert: add a message to noop action This prepares for the arrival of a second "not touching file" action: revert of an untracked file.
Fri, 01 Aug 2014 11:41:56 -0700 revert: simplify loop conditional
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 01 Aug 2014 11:41:56 -0700] rev 22233
revert: simplify loop conditional The two breaks can be joined into one. The code gains one level of indent.
Tue, 24 Jun 2014 18:04:13 +0100 revert: explode the action tuple in the for loop
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 24 Jun 2014 18:04:13 +0100] rev 22232
revert: explode the action tuple in the for loop noop is about to gain a message.
Sat, 02 Aug 2014 12:45:34 -0700 revert: use actions[...] in all disptable cases
Pierre-Yves David <pierre-yves.david@fb.com> [Sat, 02 Aug 2014 12:45:34 -0700] rev 22231
revert: use actions[...] in all disptable cases 1. Special cases are not special enough 2. There are two cases where nothing is done and a message is displayed. This prepares it.
Tue, 24 Jun 2014 17:54:33 +0100 revset: factorize backup decision
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 24 Jun 2014 17:54:33 +0100] rev 22230
revset: factorize backup decision The conditional controlling the creation of backup is fairly big. We move config related decisions outside of the loop.
Tue, 24 Jun 2014 17:44:31 +0100 revert: use a flat dispatch table
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 24 Jun 2014 17:44:31 +0100] rev 22229
revert: use a flat dispatch table Now that the table is simpler, remove one level of depth from it. This simplifies its usage in the for loop.
Fri, 15 Aug 2014 18:26:21 -0700 pushbookmark: do not attempt to update bookmarks if the push failed (BC)
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 15 Aug 2014 18:26:21 -0700] rev 22228
pushbookmark: do not attempt to update bookmarks if the push failed (BC) Before this patch, there was always an attempt to update bookmark even if prior steps of the push failed. I cannot see a good semantic reason to do so. We disable this possibility to simplify the push flow with bundle2. Bookmarks will be included in the bundle and fail with other steps.
Fri, 15 Aug 2014 17:58:15 -0700 pushbookmark: remove a <cond> and <val> or <other> construct
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 15 Aug 2014 17:58:15 -0700] rev 22227
pushbookmark: remove a <cond> and <val> or <other> construct We make the conditional explicit for the sake of readability.
Fri, 15 Aug 2014 16:31:06 -0700 pushbookmark: stop unrolling ancestors
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 15 Aug 2014 16:31:06 -0700] rev 22226
pushbookmark: stop unrolling ancestors Now that ancestors has the same boolean property as a list, we can stop unrolling the set of ancestors. This should provide a significant speedup to this step as ancestor objects are smart and lazy.
Fri, 15 Aug 2014 15:57:50 -0700 ancestors: add a __nonzero__ method
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 15 Aug 2014 15:57:50 -0700] rev 22225
ancestors: add a __nonzero__ method This allows using the object in a conditional the same way we can use list.
(0) -10000 -3000 -1000 -300 -100 -10 +10 +100 +300 +1000 +3000 +10000 tip