match: use re2 in readpatternfile if possible This has a small, but measurable, effect on performance if a pattern file is very large. In an artificial test with 200,000 lines of pattern data, using re2 reduced read time by 200 milliseconds.

test-hgignore.t: add tests for comments Although support for comments in hgignore files has existed for a while, it was previously untested.

help: fix help -c/help -e/help -k Before, hg help -c was the same as hg help, now it only shows commands. Before, hg help -e was the same as hg help, now it only shows extensions. Before, hg help -k crashed, now it shows all topics.

help: call filtercmd from topicmatch update test coverage to explicitly define when help -c should list debug/deprecated items.

help: refactor filtercmd

transplant: use Oxford comma

crecord: add dictionary to default return value of filterpatch When committing interactively without changes, the user would get a ValueError exception. This patch adds a dictionary to the return value of filterpatch when there are no files to change.

paths: include #fragment again Since 5f2a4fc3c4fa, #fragment was missing in "hg paths" output because path.loc was changed to a parsed URL. "hg paths" should use path.rawloc to show complete URLs.

discovery: properly filter changeset in 'peer.known' (issue4982) The 'peer.known' call (handled at the repository level) was applying its own manual filtering (looking at phases) instead of relying on the repoview mechanism. This led to the discovery finding more "common" node that 'getbundle' was willing to recognised. From there, bad things happen, issue4982 is a symptom of it. While situations like described in issue4982 can still happen because of race conditions, fixing 'peer.known' is important for consistency in all cases. We update the code to use 'repoview' filtering. This lead to small changes in the tests for exchanging obsolescence marker because the discovery yields different results. The test affected in 'test-obsolete-changeset-exchange.t' is a test for issue4982 getting back to its expected state.

test: add an extra base changeset in test-obsolete.t A fix to issue4982 (not fixed in this patch) will reinforce the filtering during discovery. This will makes two of our test repositories appear unrelated (because all common content is properly hidden). To avoid this, we introduce an extra base changeset that will not get obsoleted. This affects various test output so we put this addition in its own changeset.