rhg: Propagate permission errors when finding a repository The Rust standard library has a `Path::is_dir` method that returns false for any I/O error (such as a permission error), not just "No such file or directory". Instead add an `is_dir` function that returns false for non-directories and for "No such file or directory" errors, but propagates other I/O errors. Differential Revision: https://phab.mercurial-scm.org/D11230

rhg: Add build and config instructions to the README file This adds documentation explaining how to compile, configure, and use rhg as well as how the fallback mechanism works. Differential Revision: https://phab.mercurial-scm.org/D11229

dirstate: use `add` in the deprecation message about `add` The previous message was talking about `remove`. Differential Revision: https://phab.mercurial-scm.org/D11224

help: correct config.profiling.freq name (frequency->freq) Differential Revision: https://phab.mercurial-scm.org/D11217

run-tests: use a small timeout for chg instance There is case where the test runner fails to clean up the temporary files in that case, spawned chg instance can stay around for 1 hours. Getting them to shut down sooner cannot hurt. (We should also use a more robust approach for this cleanup) Differential Revision: https://phab.mercurial-scm.org/D11227

run-tests: do not inherit file descriptor when running a command This is one of the difference between python2 and python3 and could have been a reason why test hang with python2 + chg. This does not seems to help the hanging issue at all… However, now that this is written lets reduce the difference between python2 and python3. Differential Revision: https://phab.mercurial-scm.org/D11226

dummyssh: make sure we don't inherit files descriptor to the children This is one of the difference between python2 and python3 and could have been a reason why test hang with python2 + chg. This does not seems to help the hanging issue at all… However, now that this is written lets reduce the difference between python2 and python3. Differential Revision: https://phab.mercurial-scm.org/D11225

tests: make test-serve works on system that allow user to bind low port It is possible to encounter linux system configured in a way that allow port < 1024 to be bound by any users. So we update a test to focus more on the actual test: "resolving `daytime` to an actual port number. The new auto-scaling CI runner provided by clever cloud is doing so. This is the initial motivation for this change, but it seems useful anyway. Differential Revision: https://phab.mercurial-scm.org/D11228

git: restore basic functionality (issue6545) It looks like a big refactor happened on dirstate, and the git extension was just ignored. Differential Revision: https://phab.mercurial-scm.org/D11234

dirstate: fix typo in docstring Spotted while repairing git extension tests. Differential Revision: https://phab.mercurial-scm.org/D11233

typing: add several assertions to dirstatemap to appease pytype I think it's been mentioned in IRC that these can't be None in this case. This fixes: File "/mnt/c/Users/Matt/hg/mercurial/dirstatemap.py", line 213, in addfile: unsupported operand type(s) for &: 'None' and 'int' [unsupported-operands] No attribute '__and__' on None or '__rand__' on int Called from (traceback): line 290, in reset_state File "/mnt/c/Users/Matt/hg/mercurial/dirstatemap.py", line 214, in addfile: unsupported operand type(s) for &: 'None' and 'int' [unsupported-operands] No attribute '__and__' on None or '__rand__' on int Called from (traceback): line 290, in reset_state Differential Revision: https://phab.mercurial-scm.org/D11235

help: indicate how to run downgrade a repository using persistent nodemap We have a couple of report of people needing this. I am not fan of pointing people to a debug command, but we don't have much better to offer right now Differential Revision: https://phab.mercurial-scm.org/D11214

help: use the correct spelling for `slow-path` in persistent nodemap help Differential Revision: https://phab.mercurial-scm.org/D11213

fix: use scmutil.movedirstate() instead of reimplementing I wrote this patch 2 years ago as a little cleanup. I wanted to generally used `scmutil.movedirstate()` instead of manually updating the dirstate because that is easy to get wrong. I didn't know until today that the current code had a bug. So I added the test case two patches before this one and dusted off this one patch. This is a little slower than the previous code, as it diffs two manifests. However, it fixes the bug and I don't think it's going to be noticeably slower anyway. Differential Revision: https://phab.mercurial-scm.org/D11210

fix: rewrite writeworkingdir() to explicitly not work with merges `hg fix` errors out early if there is an unfinished merge, so we should have only one parent here. Making that explicit makes my next patches simpler. Differential Revision: https://phab.mercurial-scm.org/D11209

tests: demonstrate bug in `hg fix` with incorrectly dirty working copy If the parent commit needs formatting but the working copy already has the correct formatting, then the working copy will be reported as modified even though it's clean (because the size in the dirstate is incorrect). Because the bug only occurs when the size changes, I modified the formatter used in the test case to remove repeated spaces. Differential Revision: https://phab.mercurial-scm.org/D11208

upgrade: byteify an i18n message Differential Revision: https://phab.mercurial-scm.org/D11207

typing: convert an annotation to an assertion in commands.py Pytype was happy with the annotation at one point, but 2021.04.15 now complains. Differential Revision: https://phab.mercurial-scm.org/D11206

test: remove `sleep` usage in `test-nointerrupt.t` (issue6271) We move from sleep based synchronisation to file creation based synchronisation. Sleeps is the path to the dark side. Sleeps leads to flakiness. Flakiness leads to anger. Anger leads to hate. Hate leads to suffering. Differential Revision: https://phab.mercurial-scm.org/D11205

Added signature for changeset d7515d29761d

Added tag 5.9rc0 for changeset d7515d29761d

branching: merge default into stable This mark the start of the 5.9 freeze.

relnotes: document the change in the dirstate API Differential Revision: https://phab.mercurial-scm.org/D11200

dirstate: deprecate the `add` method All users have been migrated. Differential Revision: https://phab.mercurial-scm.org/D11199

mq: replace `add` call with newer API Differential Revision: https://phab.mercurial-scm.org/D11198

largefile: use `update_file` instead of `add` in `synclfdirstate` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11197

largefile: use `update_file` instead of `add` in `mergerecordupdates` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11196

dirstate: deprecate the `drop` method All users have been migrated. Differential Revision: https://phab.mercurial-scm.org/D11195

narrow: stop using `drop` in the `updateworkingcopy` Let us use the new API instead. Differential Revision: https://phab.mercurial-scm.org/D11194

mq: replace `drop` call with newer API Differential Revision: https://phab.mercurial-scm.org/D11193

largefile: use `update_file` instead of `drop` during `rollback` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11192

largefile: use `update_file` instead of `drop` in `synclfdirstate` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11191

sparse: use `update_file` instead of `drop` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11190

sparse: use `update_file` instead of `drop` in `refreshwdir` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11189

amend: use `update_file` instead of `drop` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11188

context: use `update_file` instead of `drop` in `markcommitted` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11187

dirstate: deprecate the `merge` method in all cases All code have been migrated to the new APIs. Differential Revision: https://phab.mercurial-scm.org/D11186

mq: drop the use of `dirstate.merged` Since mq does not work on merge, we do not need this. Differential Revision: https://phab.mercurial-scm.org/D11185

dirstate: deprecate the `otherparent` method in all cases All code have been migrated to the new APIs. Differential Revision: https://phab.mercurial-scm.org/D11184

dirstate: deprecate the `normallookup` method in all cases All code have been migrated to the new APIs. Differential Revision: https://phab.mercurial-scm.org/D11183

narrow: stop using `normallookup` during a test Differential Revision: https://phab.mercurial-scm.org/D11182

narrow: use `update_file` instead of `normallookup` after update This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11181

test: use the internal `_normallookup` in `test-rebuildstate.t` This is a low level test doing low level manipulation. Differential Revision: https://phab.mercurial-scm.org/D11180

sparse: use `update_file` instead of `normallookup` in refreshwdir This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11179

keyword: use `update_file_p1` instead of `normallookup` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11178

fix: use `set_possibly_dirty` instead of `normallookup` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11177

eol: use `set_possibly_dirty` instead of `normallookup` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11176

mq: replace `normallookup` call with newer API This align MQ behavior with what what `scmutil.movedirstate` does. (it should probably use `scmutil.movedirstate` itself. Differential Revision: https://phab.mercurial-scm.org/D11175

revert: use `set_possibly_dirty` instead of `normallookup` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11174

dirstate: enforce `possibly_dirty` in `set_tracked` There is some usecase (like `hg revert`) that requires more agressive `possibly_dirty` setting. So we take a safe path and enforce it in one of the main `normallookup` replacement. Differential Revision: https://phab.mercurial-scm.org/D11173

record: use `update_file` instead of `normallookup` We are cheating a bit to enforce we are in a pending change context. This will have to be cleaned up later. The end goal is reached, we are now using the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11172

copy: use `set_tracked` instead of `normallookup` in `dirstatecopy` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11171

amend: use `update_file` instead of `normallookup` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11170

mergestate: use `update_file` to handle for `ACTION_EXEC` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11169

mergestate: use `update_file` to handle for `ACTION_ADD_MODIFIED` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11168

largefile: use `update_file` for `synclfdirstate` "m" case This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11167

largefile: use `update_file` for `synclfdirstate` "n" case This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11166

largefile: replace the `normallookup` call when creating a new lfdirstate This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11165

largefile: use `update_file` instead of `normallookup` in `updatelfiles` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11164

largefile: use `set_possibly_dirty` instead of `normallookup` Differential Revision: https://phab.mercurial-scm.org/D11163

dirstate: add a `set_possibly_dirty` method This method will be able to replace some usage of `normallookup` in the future. Differential Revision: https://phab.mercurial-scm.org/D11162

dirstate: deprecate the `normal` method in all cases All code have been migrated to the new APIs. Differential Revision: https://phab.mercurial-scm.org/D11161

test: use `set_tracked` in `test-context` This is apparently the last user of the old API. Differential Revision: https://phab.mercurial-scm.org/D11160

mq: replace usage of `normal` with newer API Differential Revision: https://phab.mercurial-scm.org/D11159

largefile: use `update_file` instead of `normal` in `synclfdirstate` This is the newer, more semantic API. This was the last call to `normal` in largefile. Differential Revision: https://phab.mercurial-scm.org/D11158

largefile: use `set_clean` instead of `normal` in `repo.status` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11157

largefile: use `set_clean` instead of `normal` in `lfdirstatestatus` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11156

largefile: use `update_file` instead of `normal` in `updatelfiles` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11155

largefile: respect the `normal` signature The `parentfiledata` parameter was missing, we throw it away because I am not sure what to do with it in the largefile case. Differential Revision: https://phab.mercurial-scm.org/D11154

keyword: use `set_clean` instead of `normal` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11153

sparse: use `update_file` instead of `normal` in `refreshwdir` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11152

sparse: use `update_file` instead of `normal` during `applyupdates` This is the newer, more semantic API. (more content end up "nonnormal", see previous commit) Differential Revision: https://phab.mercurial-scm.org/D11151

sparse: apply update with in a `parentchange` context We are changing the reference so we should be within such context manager. This seems make the actual dirstate content a bit flaky with content being sometime ambigous (but maybe it was flaky before?) So I increased the matching. Differential Revision: https://phab.mercurial-scm.org/D11150

revert: use `set_clean` instead of `normal` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11149

context: use `update_file` instead of `normal` in `markcommitted` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11148

context: use new API instead of `normal` during fixup post status We use `set_clean` or `update_file` depending of if we are in the middle of an update or not. Differential Revision: https://phab.mercurial-scm.org/D11147

dirstate: introduce a `set_clean` method This will provide a good alternative to `normal` call with a narrower semantic. Differential Revision: https://phab.mercurial-scm.org/D11146

largefile: use `update_file` instead of `normal` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11145

largefile: adjust the dirstate post update within a `parentchange` context This is doing an update, so this seems more appropriate. No other change have been made, but the next changeset will :-) Differential Revision: https://phab.mercurial-scm.org/D11144

dirstate: deprecate `dirstate.remove` in all cases This will make sure that code will use the newer, more semantic API sooner than later. Differential Revision: https://phab.mercurial-scm.org/D11143

largefile: use `update_file` instead of `remove` in `synclfdirstate` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11142

largefile: rearrange conditionnal in `synclfdirstate` We can liquidate the special case early, so do we. Differential Revision: https://phab.mercurial-scm.org/D11141

largefile: use `update_file` instead of `remove` in `mergerecordupdates` This is the newer, more semantic API. Differential Revision: https://phab.mercurial-scm.org/D11140

mq: use `update_file_p1` instead of `remove` when adjusting dirstate This is the new API. Differential Revision: https://phab.mercurial-scm.org/D11139

dirstate: properly update `_lastnormaltime` in `update_file_p1` This was previously overlooked. Differential Revision: https://phab.mercurial-scm.org/D11138

dirstate: properly update `_lastnormaltime` in `update_file` This was previously overlooked. Differential Revision: https://phab.mercurial-scm.org/D11137

dirstate: use `reset_state` in `update_file_p1` Going through the same API is more consistent and allow us to push implementation lower down the call stack. Differential Revision: https://phab.mercurial-scm.org/D11136

dirstate: rename `update_file_reference` to `update_file_p1` This is a bit clearer on the intended usage of the function. (but still not great) Differential Revision: https://phab.mercurial-scm.org/D11135

dirstate-map: move most of `dirstate.update_file` logic in the dsmap A new `reset_state` method is introduced to deal with most of that logic. This move things one layer lower, but the ultimate goal is to deal with most of this at the DirstateItem level. This reveal various imperfection with the data passed to update_file by `mergestate.recordupdates`, however this is orthogonal to this patch and should be dealt with at a higher level. Differential Revision: https://phab.mercurial-scm.org/D11134

dirstate: replace `update_parent_file_data` with simpler `update_parent` call This make the dirstate API simpler. Differential Revision: https://phab.mercurial-scm.org/D11133

dirstate: factor out the part retrieve "filedata" out of `normal` We will need them elsewhere. Differential Revision: https://phab.mercurial-scm.org/D11132

dirstate-map: factor out the change to _dirs and _alldirs on removing This logic is complicated enough to deserves its own function. So it now does. This will make it easier to reuse that logic in later changeset. Differential Revision: https://phab.mercurial-scm.org/D11131

dirstate-map: factor out the change to _dirs and _alldirs on dropping This logic is complicated enough to deserves its own function. So it now does. This will make it easier to reuse that logic in later changeset. Differential Revision: https://phab.mercurial-scm.org/D11130

dirstate-map: factor out the change to _dirs and _alldirs on adding This logic is complicated enough to deserves its own function. So it now does. This will make it easier to reuse that logic in later changeset. Differential Revision: https://phab.mercurial-scm.org/D11129

dirstate-item: introduce a `dm_otherparent` property See inline documentation for details. Differential Revision: https://phab.mercurial-scm.org/D11124

dirstate-item: introduce a `dm_nonnormal` property See inline documentation for details. Differential Revision: https://phab.mercurial-scm.org/D11123

dirstate-v2: Reserve a few bytes of space for future extensions See doc-comment Differential Revision: https://phab.mercurial-scm.org/D11101

dirstate-v2: Separate iterators for dirfoldmap and debugdirstate `dirstatemap.dirfoldmap` was recently changed to re-use a Rust iterator that was added for the `hg debugdirstate` command. That iterator was based on all nodes in the tree dirstate without an entry only existing to hold child nodes, and therefore being directories. However to optimize status further we may want to store additional nodes for unknown or ignored files and directories. At that point the two users of this iterator will want different things, so let’s make two iterators instead. See doc-comments in `dispatch.rs`. Differential Revision: https://phab.mercurial-scm.org/D11099

dirstate-v2: Move fixed-size tree metadata into the docket file Before this changeset, the dirstate-v2 data file contained not only nodes and paths that may be reused when appending to an existing file, but also some fixed-size metadata that applies to the entire tree and was added at the end of the data file for every append. This moves that metadata into the docket file, so that repeated "append" operations without meaningful changes don’t actually need to grow any file. Differential Revision: https://phab.mercurial-scm.org/D11098

dirstate-v2: Add heuristic for when to create a new data file … instead of appending to the existing one. This is based on keeping track of how much of the existing data is not used anymore. Differential Revision: https://phab.mercurial-scm.org/D11097

dirstate-v2: Reuse existing paths when appending to a data file When writing a dirstate in v2 format by appending to an existing data file, filenames / paths that are borrowed from the previous on-disk representation can be reused. Differential Revision: https://phab.mercurial-scm.org/D11096

dirstate-v2: Reuse existing nodes when appending to a data file When writing a dirstate in v2 format by appending to an existing data file, nodes that are still "unparsed" from the previous on-disk representation have been unchanged and can therefore be reused. This makes the new data point to previously-existing data for tree nodes. Differential Revision: https://phab.mercurial-scm.org/D11095

dirstate-v2: Support appending to the same data file For now we’re still writing the entire data every time, so appending is not useful yet. Later we’ll have new nodes pointing to some existing data for nodes and paths that haven’t changed. The decision whether to append is pseudo-random in order to make tests exercise both code paths. This will be replaced by a heuristic based on the amount of unused existing data. Differential Revision: https://phab.mercurial-scm.org/D11094

dirstate-v2: shrink on-disk path lengths to 16-bits Differential Revision: https://phab.mercurial-scm.org/D11091

dirstate-v2: Rename Header to Root, move it to the end of the data file Now that they don’t have to be at the start, a given data file may contain multiple "roots". A docket only points to one of them, and previous ones are left unused to allow allow append-only in-place writing to an existing data file. Differential Revision: https://phab.mercurial-scm.org/D11090

dirstate-v2: Enforce data size read from the docket file The data file may not be shorter than its size given by the docket. It may be longer, but additional data is ignored. Differential Revision: https://phab.mercurial-scm.org/D11089

dirstate-v2: Introduce a docket file .hg/dirstate now only contains some metadata to point to a separate data file named .hg/dirstate.{}.d with a random hexadecimal identifier. For now every update creates a new data file and removes the old one, but later we’ll (usually) append to an existing file. Separating into two files allows doing the "write to a temporary file then atomically rename into destination" dance with only a small docket file, without always rewriting a lot of data. Differential Revision: https://phab.mercurial-scm.org/D11088

dirstate: replace a dead conditional branch with an assert in `update_file` This is a case we never meet, so lets trim it away to simplify the code before more changes. Differential Revision: https://phab.mercurial-scm.org/D11128

dirstate-map: do not use `size` to gate copy dropping during remove_file This get us close to moving the block right above withing the DirstateItem object. Doing so will help us getting rid of magic constant at the dirstatemap level. Differential Revision: https://phab.mercurial-scm.org/D11127

dirstate: drop a duplicated assert This very case is checked in 3 line above that one. Differential Revision: https://phab.mercurial-scm.org/D11126

dirstate: drop duplicated check This is covered by the `@requires_parents_change` decorator that this function use. Differential Revision: https://phab.mercurial-scm.org/D11125

dirstate: add a `set_possibly_dirty` in `fakedirstatewritetime` Differential Revision: https://phab.mercurial-scm.org/D11122

dirstatemap: use `set_possibly_dirty` in `clearambiguoustimes` lets put this new method to use Differential Revision: https://phab.mercurial-scm.org/D11121

dirstate-item: use `set_possibly_dirty` in `pure.pack_dirstate` Lets make use of the new function. Differential Revision: https://phab.mercurial-scm.org/D11120

dirstate-item: add a `set_possibly_dirty` method See inline documentation for details. The pushes the AMBIGUOUS_TIME implementation further down the line within the DirstateItem only. When this cleanup is done we will be able to stop using this representation internally. Differential Revision: https://phab.mercurial-scm.org/D11119

dirstate-item: add a `from_v1_data` constructor This class method is dedicated to building a DirstateItem from the data available in the "dirstate-v1" format. Since that format is frozen, this constructor will never change (unlike the `__init__` one). Differential Revision: https://phab.mercurial-scm.org/D11118

dirstate-item: use an explicit __init__ function instead of the attrs one For now, this is not doing anything special, however we plan to make it different in the future. So we start simple. Differential Revision: https://phab.mercurial-scm.org/D11117

dirstate: deprecated `drop` outside of `update/merge` All core users have been migrated. Differential Revision: https://phab.mercurial-scm.org/D11116

dirstate: deprecated `remove` outside of `update/merge` All core users have been migrated. Differential Revision: https://phab.mercurial-scm.org/D11115

dirstate: deprecate the `add` method outside of update/merge context All core users have been updated. Differential Revision: https://phab.mercurial-scm.org/D11114