Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 19:06:00 +0100] rev 34438
cext: reorder #include
We mostly abide by this style.
In one case, a blank line was inserted to prevent a local
`#include "file"` from coming before a `#include <file>`.
Differential Revision: https://phab.mercurial-scm.org/D908
Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 19:02:43 +0100] rev 34437
cext: move braces for control statements to same line
This seems to be the prevailing style in the code by a wide margin.
Differential Revision: https://phab.mercurial-scm.org/D907
Saurabh Singh <singhsrb@fb.com> [Mon, 02 Oct 2017 19:17:04 +0100] rev 34436
registrar: fixing typo in comment
I was just going through the module and noticed the typo. This commit
fixes 'onfalure' -> 'onfailure'.
Differential Revision: https://phab.mercurial-scm.org/D906
Alex Gaynor <agaynor@mozilla.com> [Fri, 29 Sep 2017 15:49:20 +0000] rev 34435
style: never put multiple statements on one line
Differential Revision: https://phab.mercurial-scm.org/D905
Siddharth Agarwal <sid0@fb.com> [Mon, 02 Oct 2017 18:18:57 +0100] rev 34434
annotate: mark lines affected by skip-annotate with *
This is to prevent weird surprises from happening with skips being attributed
to the wrong changeset.
.. feature::
`hg annotate --skip` now prints a `*` on lines with skipped revisions
Differential Revision: https://phab.mercurial-scm.org/D900
Siddharth Agarwal <sid0@fb.com> [Mon, 02 Oct 2017 02:34:47 -0700] rev 34433
annotate: track whether a particular annotation was the result of a skip
We're going to expose this information in the UI in an upcoming patch.
Differential Revision: https://phab.mercurial-scm.org/D899
Siddharth Agarwal <sid0@fb.com> [Mon, 02 Oct 2017 02:34:47 -0700] rev 34432
annotate: introduce attr for storing per-line annotate data
We're going to extend this a bit -- at first by simply adding whether this was
a skipped child. We're well on our way to outgrowing tuples, though -- adding
more and more fields to tuples becomes annoying very quickly.
Differential Revision: https://phab.mercurial-scm.org/D898
Siddharth Agarwal <sid0@fb.com> [Mon, 02 Oct 2017 02:34:47 -0700] rev 34431
context: rename local 'attr' to 'attr_'
In the next diff we're going to import mercurial.thirdparty.attr, and pyflakes
complains about this if this rename isn't done.
Differential Revision: https://phab.mercurial-scm.org/D897
Siddharth Agarwal <sid0@fb.com> [Mon, 02 Oct 2017 02:34:47 -0700] rev 34430
annotate: move annotatepair unit tests to a separate file
In upcoming patches the output is going to be significantly longer than it is
today, and doctests don't allow wrapping the output.
Differential Revision: https://phab.mercurial-scm.org/D896
Siddharth Agarwal <sid0@fb.com> [Mon, 02 Oct 2017 02:34:47 -0700] rev 34429
check-code: allow an exception for camelcase where required
unittest has a `maxDiff` parameter which has to be set to `None` in order for
large enough failure diffs to be displayed. Add a comment to disable the
camelcase check for `self.maxDiff = None` lines.
Differential Revision: https://phab.mercurial-scm.org/D895